Skip to content

only run docs review on internal PR's #6123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2024
Merged

only run docs review on internal PR's #6123

merged 1 commit into from
Aug 2, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Aug 2, 2024 •
edited
Loading

Proposed changes

Do not run docs preview workflows in forked PR as they do not have access to secrets.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner August 2, 2024 08:36
@github-actions github-actions bot added github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Aug 2, 2024
@pdabelf5 pdabelf5 merged commit f549105 into main Aug 2, 2024
@pdabelf5 pdabelf5 deleted the docs-forked branch August 2, 2024 08:47
@nginx-jack nginx-jack mentioned this pull request Aug 12, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

+1 more reviewer

@j1m-ryan j1m-ryan j1m-ryan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
chore Pull requests for routine tasks github_actions Pull requests that update Github_actions code
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pdabelf5 @j1m-ryan @vepatel @AlexFenlon