-
Notifications
You must be signed in to change notification settings - Fork 105
feat: Set up NGF integration to N1 Console #902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview will be available once build job completes!
|
In NIC, the doc provided both the Helm and Manifests options for deploying. We'd want to do the same for NGF, and also include an option to deploy NGF using |
Co-authored-by: bjee19 <[email protected]>
Co-authored-by: Alan Dooley <[email protected]>
Now that I've re-reviewed the Figma, I need to come up with a new file, probably |
Co-authored-by: Saylor Berman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm after remaining comments from Saylor are resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Extensively revised (14 Aug, midday), after extensive discussions with @bjee19 , @sylwang , and @sjberman
Proposed changes
Set up NGF integration into N1 Console.
<!-- in comments -->
to the UI and steps that we're using in that processThe primary build page is here: https://frontdoor-test-docs.nginx.com/previews/docs/902/nginx-one/k8s/add-ngf/
I think there's work to be done w/r/t data plane keys. We have a bunch of different ways to create them
This might close issue 660.
Closes #ISSUE
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.md
Footnotes
Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩