Skip to content

Add when: block #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2022
Merged

Add when: block #1261

merged 1 commit into from
Feb 4, 2022

Conversation

@mahesh-panchal
Copy link
Member

@mahesh-panchal mahesh-panchal commented Feb 4, 2022

Add's when: block to all the modules to be in line with nf-core/tools#1393

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd

maxulysse
maxulysse approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@mahesh-panchal mahesh-panchal merged commit e20e57f into nf-core:master Feb 4, 2022
@mahesh-panchal mahesh-panchal deleted the add_when branch February 4, 2022 08:53
@JoseEspinosa JoseEspinosa mentioned this pull request Feb 4, 2022
Merged
@grst grst mentioned this pull request Feb 9, 2022
Merged
14 tasks
@drpatelh drpatelh mentioned this pull request Feb 9, 2022
Merged
14 tasks
muffato referenced this pull request in sanger-tol/nf-core-modules Feb 14, 2022
@muffato @drpatelh
Added the when: block, as per #1261
12fe437 
Co-authored-by: Harshil Patel <[email protected]>
drpatelh added a commit that referenced this pull request Feb 14, 2022
@muffato @drpatelh
First version of the biobambam/bammarkduplicates2 module (#1247)
04e82ec 
* First version of the biobambam/bammarkduplicates2 module

* Fixed the path of versions.yml

* Regenerated the checksums as the previous files were generated with a single core

* Added the `when:` block, as per #1261

Co-authored-by: Harshil Patel <[email protected]>

Co-authored-by: Harshil Patel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxulysse maxulysse maxulysse approved these changes

@JoseEspinosa JoseEspinosa Awaiting requested review from JoseEspinosa

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mahesh-panchal @maxulysse