Skip to content

Conversation

@rakekniven
Copy link
Member

No description provided.

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add non-breaking space (or at least whitespace) before that

@rakekniven
Copy link
Member Author

Please see https://docs.nextcloud.com/server/latest/developer_manual/basics/translations.html#dos-and-don-ts and all the existing strings at Tx.
No spaces necessary here.

@nickvergessen
Copy link
Member

@rakekniven that is exactly what we are changing with nextcloud/docker-ci#820 and that was already updated in the dos and don'ts 😉

@ShGKme
Copy link
Contributor

ShGKme commented Aug 31, 2025

No spaces necessary here.

@rakekniven You was the one, approved forcing space in the ESLint config :P

@rakekniven rakekniven requested a review from Antreesy September 1, 2025 09:09
@rakekniven
Copy link
Member Author

@ShGKme @nickvergessen Sorry for the noise. Must have been a bit late in the day ;-)

@Antreesy Antreesy merged commit 429c8d3 into main Sep 1, 2025
55 checks passed
@Antreesy Antreesy deleted the rakekniven-patch-1 branch September 1, 2025 11:28
@Antreesy Antreesy added this to the v22.0.0-rc.1 milestone Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants