Skip to content

feat(translations): validate non-breaking space before ellipsis #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(translations): validate non-breaking space before ellipsis #820

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions translations/validateTranslationFiles.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,15 @@ if [ $(jq '.translations | keys[]' l10n/en_GB.json | grep '\.\.\.' | wc -l) -ne
EXIT_CODE=4
fi

# Confirm English source uses non-breaking space before ellipsis
if [ $(jq '.translations | keys[]' l10n/en_GB.json | grep -P '[^\x{00A0}]…' | wc -l) -ne 0 ]; then
echo "" 1>&2
echo "English source $1/l10n/en_GB.json contains ellipsis without non-breaking space before" 1>&2
echo "---" 1>&2
jq '.translations | keys[]' l10n/en_GB.json | grep -P '[^\x{00A0}]…' 1>&2
EXIT_CODE=4
fi

# Check for leading or trailing spaces
if [ $(jq '.translations | keys[]' l10n/en_GB.json | grep -E '(^\"(\s|\\t|\\n)|(\s|\\t|\\n)\"$)' | wc -l) -ne 0 ]; then
echo "" 1>&2
Expand Down