chore(deps): bump @vuepic/vue-datepicker from 11.0.2 to 12.0.1 #7767
Conversation
dependabot
bot
added
3. to review
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@dependabot rebase |
Bumps [@vuepic/vue-datepicker](https://github.com/Vuepic/vue-datepicker) from 11.0.2 to 12.0.1. - [Release notes](https://github.com/Vuepic/vue-datepicker/releases) - [Changelog](https://github.com/Vuepic/vue-datepicker/blob/main/CHANGELOG.md) - [Commits](Vuepic/vue-datepicker@v11.0.2...v12.0.1) --- updated-dependencies: - dependency-name: "@vuepic/vue-datepicker" dependency-version: 12.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/vuepic/vue-datepicker-12.0.1
branch
from
9070e26 to
7c6bf4c
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7767 +/- ##
=======================================
Coverage ? 51.58%
=======================================
Files ? 96
Lines ? 3148
Branches ? 865
=======================================
Hits ? 1624
Misses ? 1276
Partials ? 248 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
A newer version of @vuepic/vue-datepicker exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
😬😬😬 |
| } from '@nextcloud/l10n' | ||
| import VueDatePicker from '@vuepic/vue-datepicker' | ||
| import { VueDatePicker } from '@vuepic/vue-datepicker' | ||
| import * as locales from 'date-fns/locale' |
There was a problem hiding this comment.
Instead of bundling an entire date-fns/locale bundle, can we check the current locale in runtime, async load only the used locale and then render the component with the used locale?
On open, if possible...
resolved that part and size should also be resolved. |
|
Tested in both Vite and Webpack apps? |
Currently only tested it in vite apps |
|
Pushed a fix, should now work as expected in both app classes. |
| // this is a fix only for the styleguide as webpack does not have glob import | ||
| let modules: Record<string, () => Promise<{ default: Locale }>> |
There was a problem hiding this comment.
Webpack does have glob import
There was a problem hiding this comment.
Do we need it in a shared util if this is only used by a single component (for its internal dependency)?
There was a problem hiding this comment.
Basically just to clean the component
There was a problem hiding this comment.
Yes, but was discussed in another PR, if this is not a shared util, but only a part of NcDateTimePicker, it can be placed in components/NcDateTimePocker.
|
Better than with bundling everything. But still quite large. I guess, there is notthing we can do with it.
|
|
One problem I found. With default Vite and some Webpack/RSPack configs, every locale as well as its shared utils (3 modules) are new chunks. It increases number of chunks in an app significantly. And some locales needs ~4 HTTP requests. It is solvable by local bundler config, for example, by setting a new However, because these chunks are just mixed with others, it's a bit hard, requires regexp to find very specific files in Can we:
|
Well but thats a good thing here if every locale is its own chunk then the user only loads what needed - the locale will mostly not change so only the needed chunk is loaded. Nevertheless I currently check if we can avoid date-fn locales here in general as we already pass in most of the formatting our self. |
In general, it is also an issue. Having too many nano chunks instead of web-optimised is one of the reasons Rollup to be developed. I did not propose to have no chunk, but only to have 1 chunk per locale. It doesn't make sense to load 4 chunks just to have a single locale in a date-time picker. Anyway, that is not the main, but only an additional problem. The main problem is that This makes it quite complicated to configure any They are different from other "classic" chunks and may require specific handling. For example, we never need to have more than 1 locale. It is always a single locale. Thus it doesn't make sense to merge locale chunks into other modules even if they are too small, unlike normal chunks. |
|
Briefly, I'd prefer:
|
Bumps @vuepic/vue-datepicker from 11.0.2 to 12.0.1.
Release notes
Sourced from
@vuepic/vue-datepicker's releases.... (truncated)
Commits
53b37d0docs: Update docs build0f224fdchore: Resolve types2f869f1chore: Bump versionc9125d7docs: Try to resolve hydration issue on demo components6f2b19bfix:text-inputprop using default patterns instead of format default (fixe...042b968fix: Selecting more than one date inmulti-datesthrows an error (fixes #1173)b6cf6ffdocs: Add note forstart-timein migration guide (fixes #1170)c270fe1docs: Fix examples fordisabled-datesandallowed-dates(fixes #1171)8680cdfchore: Update readmea39f8d7chore: Update sonar workflowDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)