fix(NcActionRadio): follow-up fixes, promote migration to v-model #6470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
added
3. to review
susnux
reviewed
Feb 12, 2025
| setup() { | ||
| setup(props) { | ||
| if (typeof props.modelValue === 'boolean') { | ||
| Vue.util.warn('[NcActionRadio] Boolean type of `modelValue` is deprecated and will be removed in next versions') |
Contributor
There was a problem hiding this comment.
This will be only shown if set initially.
Meaning if the prop is mutated to a boolean it is not shown again
Contributor
There was a problem hiding this comment.
I think this is enough. If some app used this component with boolean when it was boolean only, it's unlikely it switch to boolean after mounting from something else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
modelValue:truebefore, now it's value of propvalue@changeemit works as beforeinput🏁 Checklist
Backport tonextrequested with a Vue 3 upgrade