test: Updated tests to use helper.loadTestAgent where applicable
#2640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2640 +/- ##
==========================================
- Coverage 97.23% 97.18% -0.05%
==========================================
Files 291 291
Lines 45941 45941
==========================================
- Hits 44670 44648 -22
- Misses 1271 1293 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jsumners-nr
reviewed
Oct 8, 2024
Contributor
jsumners-nr
left a comment
jsumners-nr
left a comment
There was a problem hiding this comment.
I need to think about this some more. I prefer the code as it was before this proposal because it is clear and easy to follow. I am also skittish about hiding more t.after definitions inside of helper functions given that each test can only have a single t.after.
Member
Author
|
I'll just close this |
Contributor
|
Sorry. I completely forgot to come back to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #2635 there was a question about
helper.loadTestAgent. It inits a mock agent and adds an after/teardown to unload the agent. This PR updates all tests that could use that instead of being verbose within the tests.