Skip to content

fix: Updated cassandra-driver instrumentation to properly trace promise based executions #2351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 17, 2024
Merged

fix: Updated cassandra-driver instrumentation to properly trace promise based executions #2351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
38fb9e6
refactor test
svetlanabrennan Jul 10, 2024
4351a56
add promise style test
svetlanabrennan Jul 12, 2024
d226f8d
wip stream test
svetlanabrennan Jul 12, 2024
7aefca5
wip add slow query test
svetlanabrennan Jul 12, 2024
5f9ae31
wip add slow query test
svetlanabrennan Jul 12, 2024
b522d44
fix slow query test
svetlanabrennan Jul 12, 2024
3e7f7e6
add stream test
svetlanabrennan Jul 15, 2024
8318b08
add stream property and fix lint
svetlanabrennan Jul 16, 2024
cb7ed62
fix missing metrics
svetlanabrennan Jul 16, 2024
243a5ae
remove stream test and runTest function
svetlanabrennan Jul 16, 2024
741f964
remove stream from instrumentation
svetlanabrennan Jul 16, 2024
3031a8c
fix verify trace segment test
svetlanabrennan Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions lib/instrumentation/cassandra-driver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ module.exports = function initialize(_agent, cassandra, _moduleName, shim) {
ClientProto,
['connect', 'shutdown'],
function operationSpec(shim, _fn, name) {
return new OperationSpec({ callback: shim.LAST, name })
return new OperationSpec({ callback: shim.LAST, name, promise: true })
}
)

Expand All @@ -39,7 +39,8 @@ module.exports = function initialize(_agent, cassandra, _moduleName, shim) {
'_execute',
new QuerySpec({
query: shim.FIRST,
callback: shim.LAST
callback: shim.LAST,
promise: true
})
)

Expand All @@ -64,7 +65,8 @@ module.exports = function initialize(_agent, cassandra, _moduleName, shim) {
'_innerExecute',
new QuerySpec({
query: shim.FIRST,
callback: shim.LAST
callback: shim.LAST,
promise: true
})
)

Expand Down Expand Up @@ -109,7 +111,8 @@ module.exports = function initialize(_agent, cassandra, _moduleName, shim) {
'batch',
new QuerySpec({
query: findBatchQueryArg,
callback: shim.LAST
callback: shim.LAST,
promise: true
})
)
}
Expand Down
Loading