-
Notifications
You must be signed in to change notification settings - Fork 133
Fix issue in ASGI header consumption #1578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TimPansino
wants to merge
8
commits into
main
Choose a base branch
from
fix-asgi-headers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+61
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅MegaLinter analysis: Success
See detailed reports in MegaLinter artifacts |
dffcbf1 to
dd03cf0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1578 +/- ##
=======================================
Coverage 81.81% 81.82%
=======================================
Files 207 207
Lines 23965 23970 +5
Branches 3801 3803 +2
=======================================
+ Hits 19608 19613 +5
+ Misses 3090 3087 -3
- Partials 1267 1270 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dd03cf0 to
247e7fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Overview
When an
ASGIWebTransactionconsumes the headers from ahttp.response.startevent, it was doing so without regard to the allowable input types. When the headers are a generator, the generator was consumed by the call toprocess_response()leaving no headers remaining for the web server to send.This exact same bug was also present in ASGIBrowserMiddleware, and requires the same fix.
list()object, preserving them. Then, pass this list to bothprocess_response()and the web server.Testing
Both bug fix commits are separated for ease of testing. Reverting the commit for either
ASGIWebTransactionorASGIBrowserMiddlewarecauses the included regression test to fail. This proves the issue can be caused by either wrapper and must be fixed in both.