Skip to content

Conversation

@chaudharysaket
Copy link
Contributor

@chaudharysaket chaudharysaket commented Jul 18, 2025

  • Add proxy host which can be used by extension https requests
  • This implementation is similar to how the New Relic Go agent uses proxy

@codecov
Copy link

codecov bot commented Jul 18, 2025

Codecov Report

❌ Patch coverage is 26.92308% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.70%. Comparing base (45eb888) to head (a140647).

Files with missing lines Patch % Lines
telemetry/client.go 26.92% 18 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
- Coverage   60.64%   59.70%   -0.94%     
==========================================
  Files          32       32              
  Lines        2927     2951      +24     
==========================================
- Hits         1775     1762      -13     
- Misses       1062     1099      +37     
  Partials       90       90              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

httpClient := &http.Client{
Timeout: httpClientTimeout,
Transport: &http.Transport{
Proxy: http.ProxyFromEnvironment,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Add
TLSClientConfig: &tls.Config{
MinVersion: tls.VersionTLS12,
},
So, it will prevents the use of older, vulnerable TLS versions (TLS 1.0, TLS 1.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants