Skip to content

Fix NPE pada isConnected setelah disconnect secara manual #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2016
Merged

Fix NPE pada isConnected setelah disconnect secara manual #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions ...ho.android.service.test/src/org/eclipse/paho/android/service/test/AndroidServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,36 @@ public void testConnect() throws Exception {
}

}

/**
* Tests isConnected() returns false after a disconnect() call.
* @throws Exception
*/
public void testIsConnected() throws Exception {
IMqttAsyncClient mqttClient = null;
try {
mqttClient = new MqttAndroidClient(mContext, mqttServerURI, "testConnect");
IMqttToken connectToken = null;
IMqttToken disconnectToken = null;

assertFalse(mqttClient.isConnected());

connectToken = mqttClient.connect(null, null);
connectToken.waitForCompletion(waitForCompletionTime);

assertTrue(mqttClient.isConnected());

disconnectToken = mqttClient.disconnect(null, null);
disconnectToken.waitForCompletion(waitForCompletionTime);

assertFalse(mqttClient.isConnected());
}
finally {
if (mqttClient != null) {
mqttClient.close();
}
}
}

/**
* Test connection using a remote host name for the local host.
Expand Down
2 changes: 1 addition & 1 deletion ....eclipse.paho.android.service/src/org/eclipse/paho/android/service/MqttAndroidClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ public MqttAndroidClient(Context context, String serverURI,
*/
@Override
public boolean isConnected() {
if (mqttService != null)
if (mqttService != null && clientHandle != null)
return mqttService.isConnected(clientHandle);
else
return false;
Expand Down