test: remove certs script #7133
Merged
+80
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently have a `certs` npm script that generates self-signed certificates for use in a single zisi test. This script must be run before running tests, otherwise the zisi test in question will fail. This changeset moves this certificate generation into a test helper function, ensuring that a certificate will always be available when needed by a test. It would probably be simpler to instead generate a certificate that never expires and inline it into the fixture (eliminating the need for an available `openssl` binary), but this works fine.
ndhoule
force-pushed
the
test/remove-certs-script
branch
from
92206c1 to
7c26f81
Compare
📊 Benchmark resultsComparing with 719c17c
|
serhalp
approved these changes
Mar 25, 2025
| const testMatrix = [{ args: [] }] | ||
|
|
||
| const generateSSLCertificate = async () => { | ||
| const tmpdir = await fs.mkdtemp(path.join(os.tmpdir(), 'certs-')) |
There was a problem hiding this comment.
👁️ you look like someone who would enjoy removing the tempy dev dep :grindog:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have a
certsnpm script that generates self-signedcertificates for use in a single zisi test. This script must be run
before running tests, otherwise the zisi test in question will fail.
This changeset moves this certificate generation into a test helper
function, ensuring that a certificate will always be available when
needed by a test.
It would probably be simpler to instead generate a certificate that
never expires and inline it into the fixture (eliminating the need for
an available
opensslbinary), but this works fine.