ci: let other jobs run despite type errors #7072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows CI to actually report all the other checks when you have type errors
serhalp
force-pushed
the
ci/dont-fail-everything-on-type-errors
branch
from
f653d52 to
a302a68
Compare
📊 Benchmark resultsComparing with 31e5e59
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Because we use
tscto build our package, typechecking is coupled with building. Since building is a prerequisite step to many CI jobs, they all fail without actually running what they intend when there is a single type error.This allows CI to actually report all the other checks when you have type errors, by splitting typechecking into a separate job.
To do