fix: load internal environment variables in Envelope #5429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#5338 has changed the way the
NETLIFY_DEVenvironment variable is set. Rather than mutatingprocess.envimmediately, we set a variable in theenvobject with the typeinternal, which is processed as a type of environment variable that can't be overridden.Unfortunately, this wasn't added to the Envelope methods, and so the variable was being removed for sites with Envelope enabled.
This PR addresses that and adds some tests (to both legacy and new environment variable systems) to ensure we don't introduce this regression again.