Skip to content

Conversation

eduardoboucas
Copy link
Member

Which problem is this pull request solving?

JS client counterpart of https://github.com/netlify/netlify-server/pull/3068.

@eduardoboucas eduardoboucas requested a review from a team as a code owner September 22, 2023 14:47
@netlify
Copy link

netlify bot commented Sep 22, 2023

Deploy Preview for blobs-js ready!

Name Link
🔨 Latest commit 517afde
🔍 Latest deploy log https://app.netlify.com/sites/blobs-js/deploys/650da8f46a650000089af399
😎 Deploy Preview https://deploy-preview-50--blobs-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Sep 22, 2023
@ascorbic
Copy link
Contributor

Is this a breaking change?

@eduardoboucas
Copy link
Member Author

Is this a breaking change?

Yeah, I was just thinking about that! Technically, it is. No one is using this in production yet, and there's not really a migration path that people can follow.

It's still useful to make this a major bump, though. I'll do that.

@eduardoboucas eduardoboucas changed the title fix: use URI-encoded keys feat!: use URI-encoded keys Sep 22, 2023
@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Sep 22, 2023
@ascorbic
Copy link
Contributor

ascorbic commented Sep 22, 2023

Probably not worth it, as you said, but worth highlighting the fact internally in the project channel

@orinokai
Copy link

awesome! this'll be a big help

Copy link

@orinokai orinokai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 🚢

@eduardoboucas eduardoboucas merged commit fd8e1c6 into main Sep 25, 2023
@eduardoboucas eduardoboucas deleted the fix/encode-keys branch October 24, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants