Skip to content

feat: use accept header for signed URL #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2024
Merged

feat: use accept header for signed URL #150

merged 1 commit into from
Mar 4, 2024

Conversation

eduardoboucas
Copy link
Member

Which problem is this pull request solving?

Follow-up to #147. Sets the right accept header to retrieve a signed URL for reads.

@eduardoboucas eduardoboucas requested a review from a team as a code owner March 4, 2024 15:51
@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Mar 4, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 4, 2024 •
edited
Loading

✅ Deploy Preview for blobs-js ready!

Name Link
🔨 Latest commit 67cca9d
🔍 Latest deploy log https://app.netlify.com/sites/blobs-js/deploys/65e5ede895ec4800082f925a
😎 Deploy Preview https://deploy-preview-150--blobs-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@eduardoboucas eduardoboucas requested a review from cbosss March 4, 2024 15:51
@eduardoboucas eduardoboucas merged commit 713e2be into main Mar 4, 2024
@eduardoboucas eduardoboucas deleted the feat/accept-header branch March 4, 2024 16:15
@token-generator-app token-generator-app bot mentioned this pull request Mar 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbosss cbosss Awaiting requested review from cbosss

1 more reviewer

@Skn0tt Skn0tt Skn0tt approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eduardoboucas @Skn0tt