Skip to content

Conversation

@aaron-iles
Copy link
Contributor

Related Issue

#981

New Behavior

Adds the ability to assign a role to an inventory item via the netbox_inventory_item module. I also took the liberty to perform some linting and slight refactoring of some integration tests.

Contrast to Current Behavior

The netbox_inventory_item module cannot assign a role to an inventory item.

Discussion: Benefits and Drawbacks

  • This change is backward-compatible.
  • This will allow users to better organize inventory items and negate the need for custom scripts or API calls to assign inventory items to roles.

Changes to the Documentation

I believe all changes are self-documenting. If they are not, please let me know.

Proposed Release Note Entry

Adds the ability to assign an inventory item role to an inventory item via the netbox_inventory_item module.

Double Check

  • I have read the comments and followed the CONTRIBUTING.md.
  • I have explained my PR according to the information in the comments or in a linked issue.
  • My PR targets the devel branch.

@aaron-iles aaron-iles marked this pull request as ready for review August 15, 2023 01:14
@sc68cal
Copy link
Contributor

sc68cal commented Aug 17, 2023

Inventory item roles were introduced in v3.2.0 so you need to add the integration tests you have written to the v3.3 and v3.4 targets. Having it only in the v3.5 target is not sufficient

@aaron-iles
Copy link
Contributor Author

@sc68cal Understood. Integration tests added for targets v3.3 and v3.4.

@rodvand rodvand merged commit f55f567 into netbox-community:devel Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants