Skip to content

[client] Rename logout to deregister #4307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2025
Merged

[client] Rename logout to deregister #4307

merged 2 commits into from
Aug 8, 2025

Conversation

lixmal
Copy link
Collaborator

@lixmal lixmal commented Aug 8, 2025

Describe your changes

Issue ticket number and link

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

@Copilot Copilot AI review requested due to automatic review settings August 8, 2025 12:30
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request renames the "logout" functionality to "deregister" throughout the client UI and command line interface to better reflect the actual operation being performed. The change updates user-facing text elements while maintaining backward compatibility.

  • Renames all UI button labels, dialog titles, and messages from "logout" to "deregister"
  • Updates the CLI command from "logout" to "deregister" with "logout" as an alias for backward compatibility
  • Maintains existing function names and internal logic while only changing user-facing terminology

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
client/ui/profile.go Updates all UI text elements (buttons, dialogs, notifications) from "logout" to "deregister"
client/cmd/logout.go Renames CLI command to "deregister" with "logout" alias and updates output message

Copy link

sonarqubecloud bot commented Aug 8, 2025

@lixmal lixmal merged commit bef99d4 into main Aug 8, 2025
34 checks passed
@lixmal lixmal deleted the rename-logout branch August 8, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants