[management] during JSON migration filter duplicates on conflict #4303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a database migration issue by filtering duplicate peer entries during JSON-to-table migration to comply with uniqueness constraints. The change prevents migration failures when duplicate entries exist in the same group.
- Adds conflict handling during database migration to skip duplicate entries
- Uses GORM's OnConflict clause with DoNothing strategy to handle uniqueness violations
bcmmbaga
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
In case of dublicated peer entries in the same group we filter those during migration to comply with the uniqueness constraint.
Issue ticket number and link
#4299
Stack
Checklist