[misc]: Factorize SetFlagsFromEnvVars and support credentials #4294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…_DIRECTORY The code for setting up command flags values from environment variables was copied in three different places, this puts the helper function in the util package so that every component can use it. Furthermore, it now supports reading values from files in `$CREDENTIALS_DIRECTORY`, which allows direct integration with systemd's `LoadCredential` mechanism (but any platform can define such a variable and pass values as files).
Tom-Hubrecht
force-pushed
the
loadcredential
branch
from
80f3af6 to
07d7212
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The code for setting up command flags values from environment variables was copied in three different places, this puts the helper function in the util package so that every component can use it. Furthermore, it now supports reading values from files in
$CREDENTIALS_DIRECTORY, which allows direct integration with systemd'sLoadCredentialmechanism (but any platform can define such a variable and pass values as files).Note however that it removes support from reading values from variables of the form
WT_...which is very legacy.Issue ticket number and link
Stack
Checklist