[misc] Separate shared code dependencies #4288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR restructures the codebase to separate shared code dependencies by moving common packages from server-specific locations to a shared/ directory. This separation ensures license compliance by preventing client and shared code from importing packages that will change license.
Key changes:
- Move relay, management HTTP API, status, and context packages to
shared/directory - Update all import paths to reference the new shared locations
- Add GitHub workflow to prevent future problematic license dependencies
Reviewed Changes
Copilot reviewed 122 out of 146 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| shared/relay/constants.go | Introduces WebSocket URL path constant for shared relay usage |
| shared/relay/client/* | Updates relay client imports to use shared message and health check packages |
| shared/management/operations/operation.go | Creates shared operation type definition |
| shared/management/status/error.go | Updates import to use shared operations package |
| shared/management/http/util/util.go | Updates import to use shared status package |
| shared/management/client/rest/* | Updates REST client imports to use shared HTTP API packages |
| shared/context/keys.go | Introduces shared context key constants |
| route/route.go | Removes status package dependency, uses standard fmt.Errorf |
| relay/server/* | Updates relay server imports to use shared packages |
| management/server/* | Updates management server imports to use shared packages |
| management/server/context/keys.go | Updates to reference shared context constants |
| formatter/hook/hook.go | Updates import to use shared context package |
| client/internal/profilemanager/config.go | Removes outdated comment about hardcoded management port |
| .github/workflows/check-license-dependencies.yml | Adds workflow to prevent problematic license dependencies |
|
mlsmaycon
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Stack
Checklist