Skip to content

[management] expire invalid peer #4275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 5, 2025
Merged

Conversation

pascal-fischer
Copy link
Collaborator

Describe your changes

Issue ticket number and link

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

@Copilot Copilot AI review requested due to automatic review settings August 4, 2025 10:59
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the peer invalidation mechanism in the management server by allowing specific peers to be expired rather than invalidating all peers for an account. The change modifies the integrated validator interface to pass peer IDs when peers are invalidated, enabling more targeted peer expiration.

  • Updates the peer invalidation listener to receive specific peer IDs
  • Implements targeted peer expiration for invalid peers
  • Adds logging for debugging peer invalidation and expiration

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
management/server/integrations/integrated_validator/interface.go Updates the SetPeerInvalidationListener interface to include peer IDs
management/server/account.go Implements targeted peer invalidation with specific peer expiration
management/server/user.go Adds debug logging for peer expiration operations

bcmmbaga
bcmmbaga previously approved these changes Aug 5, 2025
Copy link

sonarqubecloud bot commented Aug 5, 2025

@pascal-fischer pascal-fischer merged commit 348d981 into main Aug 5, 2025
52 of 53 checks passed
@pascal-fischer pascal-fischer deleted the feature/edr-expiration branch August 5, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants