[management, client] Add logout feature #4268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements a logout feature that allows peers to disconnect from the NetBird management server and remove themselves. The logout functionality spans both the management server (handling logout requests) and the client daemon (providing CLI and gRPC interfaces).
- Adds a new
LogoutRPC method to the management service that deletes peers from the server - Implements client-side logout functionality through both the daemon service and CLI command
- Extends the management client interface to support logout operations
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| management/server/grpcserver.go | Implements the Logout RPC handler to delete peers from the management server |
| management/proto/*.proto | Defines the Logout RPC method in the management service protobuf interface |
| management/proto/*.pb.go | Generated protobuf code for the management service logout method |
| management/client/*.go | Adds logout functionality to management client interface and implementations |
| client/server/server.go | Implements daemon-side logout logic including connection cleanup and management server communication |
| client/proto/*.proto | Defines the Logout RPC method in the daemon service protobuf interface |
| client/proto/*.pb.go | Generated protobuf code for the daemon service logout method |
| client/cmd/*.go | Adds CLI logout command and integrates it into the root command |
|
hakansa
reviewed
Aug 2, 2025
hakansa
approved these changes
Aug 4, 2025
This was referenced Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Stack
Checklist