[management] add account deleted event #4255
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds missing support for tracking account deletion events in the management server. The change introduces a new activity code for account deletion and ensures the event is logged when an account is deleted.
- Adds
AccountDeletedactivity code with value 99999 - Implements event logging in the
DeleteAccountmethod with relevant metadata
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| management/server/activity/codes.go | Adds new AccountDeleted activity constant |
| management/server/account.go | Adds event logging call in DeleteAccount method |
| @@ -174,6 +174,8 @@ const ( | |||
|
|
|||
| AccountLazyConnectionEnabled Activity = 85 | |||
| AccountLazyConnectionDisabled Activity = 86 | |||
|
|
|||
| AccountDeleted Activity = 99999 | |||
There was a problem hiding this comment.
The activity code 99999 appears to be an arbitrary large number that doesn't follow the sequential pattern of other activity codes (85, 86). Consider using the next sequential number (87) to maintain consistency and avoid potential conflicts.
| AccountDeleted Activity = 99999 | |
| AccountDeleted Activity = 87 |
Copilot uses AI. Check for mistakes.
| @@ -174,6 +174,8 @@ const ( | |||
|
|
|||
| AccountLazyConnectionEnabled Activity = 85 | |||
| AccountLazyConnectionDisabled Activity = 86 | |||
|
|
|||
| AccountDeleted Activity = 99999 | |||
There was a problem hiding this comment.
The new AccountDeleted constant is not added to the activityMap. This will likely cause issues when the activity code needs to be mapped to its corresponding Code structure for logging or display purposes.
Copilot uses AI. Check for mistakes.
|
Describe your changes
we miss account deleted event type - this pr adds it
Issue ticket number and link
Stack
Checklist