Skip to content

Dockerfile: pin gopls to v0.18.1 (latest that supports golang 1.23) #4240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025

Conversation

Bilgeworth
Copy link
Contributor

@Bilgeworth Bilgeworth commented Jul 29, 2025

Container will fail to build with newer versions of gopls unless golang is updated to 1.24. The latest stable version supporting 1.23 is gopls v0.18.1

Describe your changes

Changed gopls@latest to [email protected] in .devcontainer/Dockerfile

Issue ticket number and link

github.com//issues/4238

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Container will fail to build with newer versions of gopls unless golang is updated to 1.24. The latest stable version supporting 1.23 is gopls v0.18.1
@Copilot Copilot AI review requested due to automatic review settings July 29, 2025 15:56
@CLAassistant
Copy link

CLAassistant commented Jul 29, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a build compatibility issue by pinning the gopls language server to version v0.18.1, which is the latest version that supports Go 1.23. This prevents container build failures that occur when using newer gopls versions with Go 1.23.

  • Pins gopls version from @latest to @v0.18.1 in the devcontainer Dockerfile
  • Ensures compatibility between Go 1.23 and the gopls language server
  • Resolves build failures mentioned in issue #4238
Comments suppressed due to low confidence (1)

.devcontainer/Dockerfile:12

  • The version v0.18.1 of gopls does not exist. The latest stable release of gopls is v0.16.2. Please verify the correct version number or use a valid version tag.
    && go install -v golang.org/x/tools/[email protected]

Copy link

@lixmal lixmal merged commit 34042b8 into netbirdio:main Jul 29, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants