[management] Log BufferUpdateAccountPeers caller #4217
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds tracing functionality to the BufferUpdateAccountPeers method to improve debugging and monitoring capabilities. The change logs the account ID and caller information whenever buffer updates are initiated for account peers.
- Adds trace-level logging to track buffer update operations and their originating callers
| @@ -1291,6 +1291,8 @@ type bufferUpdate struct { | |||
| } | |||
|
|
|||
| func (am *DefaultAccountManager) BufferUpdateAccountPeers(ctx context.Context, accountID string) { | |||
| log.WithContext(ctx).Tracef("buffer updating peers for account %s from %s", accountID, util.GetCallerName()) | |||
There was a problem hiding this comment.
The util.GetCallerName() function is called on every invocation of BufferUpdateAccountPeers, which typically involves stack inspection. Consider whether this performance overhead is acceptable for trace-level logging, especially if this method is called frequently.
| log.WithContext(ctx).Tracef("buffer updating peers for account %s from %s", accountID, util.GetCallerName()) | |
| log.WithContext(ctx).Tracef("buffer updating peers for account %s from BufferUpdateAccountPeers", accountID) |
Copilot uses AI. Check for mistakes.
|
Describe your changes
Issue ticket number and link
Stack
Checklist