-
-
Notifications
You must be signed in to change notification settings - Fork 845
[management] Add validate flow response #4172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a validate flow response feature to the management server by integrating an IntegratedValidator component. The main purpose is to enable validation of PKCE authorization flows through an integrated validator interface.
- Adds a new
ValidateFlowResponse
method to the IntegratedValidator interface - Integrates the validator into the management server to validate PKCE authorization flows
- Updates dependency version for management-integrations
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
management/server/integrations/integrated_validator/interface.go | Adds ValidateFlowResponse method to IntegratedValidator interface |
management/server/grpcserver.go | Integrates validator into GRPC server and uses it to validate PKCE flows |
management/server/integrated_validator.go | Updates mock validator to implement new interface |
management/cmd/management.go | Passes integrated validator to server constructor |
management/server/management_test.go | Updates test to include mock validator |
management/server/management_proto_test.go | Updates test to include mock validator |
management/client/client_test.go | Updates test to include mock validator |
go.mod | Updates management-integrations dependency version |
|
Describe your changes
This PR adds a validate flow response feature to the management server by integrating an IntegratedValidator component. The main purpose is to enable validation of PKCE authorization flows through an integrated validator interface.
ValidateFlowResponse
method to the IntegratedValidator interfaceIssue ticket number and link
Stack
Checklist