Skip to content

[management] Add validate flow response #4172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 18, 2025
Merged

Conversation

mlsmaycon
Copy link
Collaborator

@mlsmaycon mlsmaycon commented Jul 18, 2025

Describe your changes

This PR adds a validate flow response feature to the management server by integrating an IntegratedValidator component. The main purpose is to enable validation of PKCE authorization flows through an integrated validator interface.

  • Adds a new ValidateFlowResponse method to the IntegratedValidator interface
  • Integrates the validator into the management server to validate PKCE authorization flows
  • Updates dependency version for management-integrations

Issue ticket number and link

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

@Copilot Copilot AI review requested due to automatic review settings July 18, 2025 07:57
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a validate flow response feature to the management server by integrating an IntegratedValidator component. The main purpose is to enable validation of PKCE authorization flows through an integrated validator interface.

  • Adds a new ValidateFlowResponse method to the IntegratedValidator interface
  • Integrates the validator into the management server to validate PKCE authorization flows
  • Updates dependency version for management-integrations

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
management/server/integrations/integrated_validator/interface.go Adds ValidateFlowResponse method to IntegratedValidator interface
management/server/grpcserver.go Integrates validator into GRPC server and uses it to validate PKCE flows
management/server/integrated_validator.go Updates mock validator to implement new interface
management/cmd/management.go Passes integrated validator to server constructor
management/server/management_test.go Updates test to include mock validator
management/server/management_proto_test.go Updates test to include mock validator
management/client/client_test.go Updates test to include mock validator
go.mod Updates management-integrations dependency version

Copy link

sonarqubecloud bot commented Jul 18, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mlsmaycon mlsmaycon merged commit 08fd460 into main Jul 18, 2025
87 of 91 checks passed
@mlsmaycon mlsmaycon deleted the add-validate-flow-response branch July 18, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants