[client] avoid parsing NB_NETSTACK_SKIP_PROXY if empty #4145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This avoids to have in the logs: ``` ERRO client/iface/netstack/tun.go:46: failed to parse NB_NETSTACK_SKIP_PROXY: strconv.ParseBool: parsing "": invalid syntax ``` Signed-off-by: iisteev <[email protected]>
iisteev
force-pushed
the
parse-bool-skip-proxy
branch
from
302fb65 to
3a534bf
Compare
|
lixmal
approved these changes
Jul 13, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids to have in the logs:
Describe your changes
When you run netbird client in rootless mode and in the absence of the var
NB_NETSTACK_SKIP_PROXY, you get a parsing error in the logs. People would need to set the variable explicitly to avoid the parsing error in the logs which I don't think it was left like this on purpose?Issue ticket number and link
Stack
Checklist