Skip to content

Conversation

@CodeVac513
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Some RabbitMQ-related constants use the RQM_ prefix while others use RMQ_, causing inconsistency in naming.

Issue Number: #15786

What is the new behavior?

All constants related to RabbitMQ now consistently use the RMQ_ prefix instead of RQM_.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

coveralls commented Oct 16, 2025

Pull Request Test Coverage Report for Build 62dbcdb0-3a28-423f-9057-3ad0c21adf23

Details

  • 16 of 17 (94.12%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.687%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/microservices/client/client-rmq.ts 2 3 66.67%
Totals Coverage Status
Change from base Build 13526dc5-cac6-4c47-9387-7df665bed630: 0.0%
Covered Lines: 7275
Relevant Lines: 8203

💛 - Coveralls

@CodeVac513
Copy link
Author

CodeVac513 commented Oct 16, 2025

I've tested the failing WebSocket tests locally, and they all pass.

Also, all RabbitMQ-related tests are passing in the CI environment.
It seems like the failure might be related to flaky tests or CI environment instability, rather than the recent RabbitMQ constant renaming changes.

Let me know if you think there's anything I should double-check, or if you could please re-run the CI / advise on the next steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants