[proxy] allow for removal of project2ep and account2ep mappings #12753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradludgate
commented
Jul 26, 2025
| @@ -29,6 +29,7 @@ clap = { workspace = true, features = ["derive", "env"] } | |||
| clashmap.workspace = true | |||
| compute_api.workspace = true | |||
| consumption_metrics.workspace = true | |||
| crossbeam-skiplist = { git = "https://github.com/crossbeam-rs/crossbeam", rev = "8d24b3460bb7a9968e2ee21eeb42c16b0b5d02e9" } | |||
There was a problem hiding this comment.
The range query hacks I've done in this PR depend on the "Comparable" trait, which crossbeam-skiplist supports but has not yet been released to crates-io.
9042 tests run: 8393 passed, 0 failed, 649 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
8549b42 at 2025-07-26T19:08:56.988Z :recycle: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this PR is actually a good idea - it's a lot of complexity right now. I just wanted to scratch an itch and it did seem to work.