refactor(compaction): eliminate CompactionError::CollectKeyspaceError variant
#12517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r` variant The only differentiated handling of it is for `is_critical`, which in turn is a `matches!()` on several variants of the `enum CollectKeyspaceError` which is the value contained insided `CompactionError::CollectKeyspaceError`. This PR pushes `is_critical` down into `repartition()` and inlines it, which follows the pattern we observe for most other usages of `critical_timline!` which in turn enables us upstack to be undifferentiated about the `CompactionError::CollectKeyspaceError` variant and remove it. A drive-by fix is more precise classification of WaitLsnError::BadState when mapping to `tonic::Status`.
8635 tests run: 8008 passed, 0 failed, 627 skipped (full report)Flaky tests (2)Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
157166b at 2025-07-08T19:09:56.546Z :recycle: |
skyzh
approved these changes
Jul 9, 2025
problame
deleted the
problame/refactor-compaction-error-eliminate-collect-keyspace-variant
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only differentiated handling of it is for
is_critical, which inturn is a
matches!()on several variants of theenum CollectKeyspaceErrorwhich is the value contained insided
CompactionError::CollectKeyspaceError.This PR introduces a new error for
repartition(), allowing its immediatecallers to inspect it like
is_criticaldid.A drive-by fix is more precise classification of WaitLsnError::BadState
when mapping to
tonic::Status.refs