Skip to content

Skip new summary tests on RX session #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 26, 2025
Merged

Skip new summary tests on RX session #1262

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
00dc32b
skip tests on rx
MaxAake Feb 25, 2025
48666ba
switch TK branch
MaxAake Feb 25, 2025
06e35b9
more precise skipping
MaxAake Feb 25, 2025
706592c
revert to 5.0 testkit
MaxAake Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/testkit-backend/src/skipped-tests/rx.js
View file
Open in desktop
Copy link
Member

@robsdedude robsdedude Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smells like a regex, glob matcher, or similar predicate could simplify the code a little. No blocker though.

Copy link
Contributor Author

@MaxAake MaxAake Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea, but it'd take a rewrite of the skipping part that would make this significantly bigger PR. Worth putting on my backlog, though!

Original file line number Diff line number Diff line change
@@ -1,9 +1,19 @@
import { skip, ifEquals } from './skip.js'
import { skip, ifEquals, ifStartsWith } from './skip.js'

const skippedTests = [
skip(
'Throws after run insted of the first next because of the backend implementation',
ifEquals('stub.disconnects.test_disconnects.TestDisconnects.test_disconnect_on_tx_begin')
),
skip(
'Reactive driver does not send DISCARD on consume if records stream has been subscribed to',
ifStartsWith('stub.summary.test_summary.TestSummaryPlanDiscard'),
ifStartsWith('stub.summary.test_summary.TestSummaryCountersDiscard'),
ifStartsWith('stub.summary.test_summary.TestSummaryBasicInfoDiscard'),
ifStartsWith('stub.summary.test_summary.TestSummaryGqlStatusObjects4x4Discard'),
ifStartsWith('stub.summary.test_summary.TestSummaryGqlStatusObjects5x6Discard'),
ifStartsWith('stub.summary.test_summary.TestSummaryNotifications4x4Discard'),
ifStartsWith('stub.summary.test_summary.TestSummaryNotifications5x6Discard')
)
]

Expand Down