Avoid 3rd party imports for Java Doc. #823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of our 3rd party dependencies, `org.reactivestreams.Subscription`, was imported just for a JavaDoc. This lead to a situation where the usage of the `Config` class needs the library on the classpath. We can avoid this by using a fully qualified import in the Javadoc. I fixed the other 6 imports for consistency, even though they are from our own code.
gjmwoods
approved these changes
Feb 17, 2021
michael-simons
added a commit
that referenced
this pull request
Feb 17, 2021
One of our 3rd party dependencies, `org.reactivestreams.Subscription`, was imported just for a JavaDoc. This lead to a situation where the usage of the `Config` class needs the library on the classpath. We can avoid this by using a fully qualified import in the Javadoc. I fixed the other 6 imports for consistency, even though they are from our own code.
This was referenced Mar 8, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of our 3rd party dependencies,
org.reactivestreams.Subscription, was imported just for a JavaDoc. This lead to a situation where the usage of theConfigclass needs the library on the classpath. We can avoid this by using a fully qualified import in the Javadoc.I fixed the other 6 imports for consistency, even though they are from our own code.
I suggest cherrypicking this change into all maintained 4.x branches as well.