Logging improvements: #557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PetrJanouch
commented
Jan 21, 2019
PetrJanouch
commented
- each frame is logged only once
- server address is now part of the logging message
PetrJanouch
force-pushed
the
1.7_logging_improvements
branch
3 times, most recently
from
cb836a5 to
b5df4a4
Compare
ali-ince
reviewed
Jan 22, 2019
| return serverAddress; | ||
| } | ||
|
|
||
| private String valueOrEmpty( String value ) |
There was a problem hiding this comment.
Maybe move this into org.neo4j.driver.internal.util.Format class as a static method?
- each frame is logged only once - server address is now a part of the logging message
PetrJanouch
force-pushed
the
1.7_logging_improvements
branch
from
b5df4a4 to
04aeeb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.