Fixed error when connection killed during transaction #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connection error can happen while transaction is executing. Closing transaction after such error should not perform rollback because connection is dead and database has cleaned up all resources. Previously close operation tried to perform rollback and failed with same `ServiceUnavailable` exception as the unsuccessful `#run()`. Error thrown from `#close()` has to be added as a suppressed error to the one thrown from `#run()`, when used in try-with-resources block. So code attempted to add error to itself as suppressed. This resulted in an `IllegalArgumentException`. This commit fixes the problem by making `#close()` not perform a rollback after a fatal connection error.
New condition is the same as old one by reads a bit better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection error can happen while transaction is executing. Closing transaction after such error should not perform rollback because connection is dead and database has cleaned up all resources.
Previously close operation tried to perform rollback and failed with same
ServiceUnavailableexception as the unsuccessful#run(). Error thrown from#close()has to be added as a suppressed error to the one thrown from#run(), when used in try-with-resources block. So code attempted to add error to itself as suppressed. This resulted in anIllegalArgumentException.This PR fixes the problem by making
#close()not perform a rollback after a fatal connection error.