Fixed couple netty buffer leaks #429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`OutboundMessageHandler` writes message to `ByteBuf`. It allocates a dedicated IO buffer for this. Writing can fail for various reasons (unsupported byte arrays, etc). Previously this IO buffer has not been released in case of an error. When writing is successful IO buffer is released by then channel pipeline. This commit makes `OutboundMessageHandler` release buffer before rethrowing the exception.
Because couple tests take much more time with Netty buffer leak detector enabled with paranoid leak detection level.
zhenlineo
approved these changes
Nov 16, 2017
| { | ||
| output.stop(); | ||
| // release buffer because it will not get added to the out list and no other handler is going to handle it | ||
| messageBuf.release(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple leaks fixed in tests, one leak fixed in production code in
OutboundMessageHandler.