Clarify semantics of statement result methods #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boggle
force-pushed
the
1.0-consumption-fixes
branch
2 times, most recently
from
b0e60d0 to
3aafe26
Compare
| return emptyList(); | ||
| } | ||
| else if ( position == -1 && hasNext() ) | ||
| if ( hasNext() ) |
Contributor
There was a problem hiding this comment.
couldn't this be rewritten to a while( hasNext() )... instead of if ( hasNext() ) ... do {...} while ( hasNext() )...?
Contributor
Author
There was a problem hiding this comment.
This is so that for the empty case we can use emptyList() which returns a constant. For the non-empty case we then already know that hasNext() is true which is why that case uses a do while loop
o Also simplifies implementation to avoid unnecessary recursion
…with Java iteration
boggle
force-pushed
the
1.0-consumption-fixes
branch
from
13e5483 to
3990383
Compare
boggle
changed the title
boggle
changed the title
Contributor
|
What's the status of this PR? It is good to me. Shall we merge? |
technige
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discusssion w Nigel / same-named trello card
Also cleans up InternalStatementResult impl quite a bit which was using recursion in weird places.