Skip to content

Add getInstance to TypeSystem #1323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 24, 2022
Merged

Add getInstance to TypeSystem #1323

merged 3 commits into from
Oct 24, 2022

Conversation

@injectives
Copy link
Contributor

@injectives injectives commented Oct 22, 2022

No description provided.

michael-simons
michael-simons approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@michael-simons michael-simons left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

(Maybe getDefault() or getDefaultInstance() is a slightly better name just in case we ever should have another one)

@injectives injectives merged commit 93c7b95 into neo4j:5.0 Oct 24, 2022
@injectives injectives deleted the feature/typesystem branch October 24, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-simons michael-simons michael-simons approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@injectives @michael-simons