Remove remaining stub tests and dependency on legacy stub server #1088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injectives
force-pushed
the
feature/stubt
branch
5 times, most recently
from
396c929 to
72999de
Compare
Reactive Testkit backend enabled a lot of Testkit tests to run on reactive driver. This update removes dependency on legacy stub server that is no longer maintained. The remaining stub tests have been removed since there are similar tests in Testkit already, the tests and their respective Testkit alternatives are provided below: - `DirectDriverBoltKitIT.shouldStreamingRecordsInBatchesRx` -> `TestIterationSessionRun.test_half_batch` - Both test result consumption in batches. - `DirectDriverBoltKitIT.shouldDiscardIfPullNotFinished` -> `TestIterationSessionRun.test_discards_on_session_close` - Unlike the original, Testkit test consumes one record and discards the rest using session `run` intead of tx function. Based on its name, the original test purpose was to check if discard happens when result stream is not consumed in full and the suggested test covers this. - `RoutingDriverBoltKitIT.shouldHandleLeaderSwitchAndRetryWhenWritingInTxFunctionRX` -> `RoutingV4x4.test_should_write_successfully_on_leader_switch_using_tx_function` - Both check leader failure handling. One of examples that dependended on stub server has been brought in line with the rest of examples and uses `DatabaseExtension` to manage server.
injectives
force-pushed
the
feature/stubt
branch
from
72999de to
7787f97
Compare
gjmwoods
approved these changes
Nov 22, 2021
driver/src/test/java/org/neo4j/driver/integration/RoutingDriverBoltKitIT.java
Outdated
Show resolved
Hide resolved
injectives
added a commit
to injectives/neo4j-java-driver
that referenced
this pull request
Jan 31, 2022
…4j#1088) * Remove remaining stub tests and dependency on legacy stub server Reactive Testkit backend enabled a lot of Testkit tests to run on reactive driver. This update removes dependency on legacy stub server that is no longer maintained. The remaining stub tests have been removed since there are similar tests in Testkit already, the tests and their respective Testkit alternatives are provided below: - `DirectDriverBoltKitIT.shouldStreamingRecordsInBatchesRx` -> `TestIterationSessionRun.test_half_batch` - Both test result consumption in batches. - `DirectDriverBoltKitIT.shouldDiscardIfPullNotFinished` -> `TestIterationSessionRun.test_discards_on_session_close` - Unlike the original, Testkit test consumes one record and discards the rest using session `run` intead of tx function. Based on its name, the original test purpose was to check if discard happens when result stream is not consumed in full and the suggested test covers this. - `RoutingDriverBoltKitIT.shouldHandleLeaderSwitchAndRetryWhenWritingInTxFunctionRX` -> `RoutingV4x4.test_should_write_successfully_on_leader_switch_using_tx_function` - Both check leader failure handling. One of examples that dependended on stub server has been brought in line with the rest of examples and uses `DatabaseExtension` to manage server. * Renamed RoutingDriverBoltKitIT to ResolverIT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reactive Testkit backend enabled a lot of Testkit tests to run on reactive driver. This update removes dependency on legacy stub server that is no longer maintained.
The remaining stub tests have been removed since there are similar tests in Testkit already, the tests and their respective Testkit alternatives are provided below:
DirectDriverBoltKitIT.shouldStreamingRecordsInBatchesRx->TestIterationSessionRun.test_half_batch- Both test result consumption in batches.DirectDriverBoltKitIT.shouldDiscardIfPullNotFinished->TestIterationSessionRun.test_discards_on_session_close- Unlike the original, Testkit test consumes one record and discards the rest using sessionrunintead of tx function. Based on its name, the original test purpose was to check if discard happens when result stream is not consumed in full and the suggested test covers this.RoutingDriverBoltKitIT.shouldHandleLeaderSwitchAndRetryWhenWritingInTxFunctionRX->RoutingV4x4.test_should_write_successfully_on_leader_switch_using_tx_function- Both check leader failure handling.One of examples that dependended on stub server has been brought in line with the rest of examples and uses
DatabaseExtensionto manage server.