Fix OpenAILLM and http_client type #404
Draft
+685
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -35,6 +36,24 @@ def test_openai_llm_missing_dependency(mock_import: Mock) -> None: | |||
| OpenAILLM(model_name="gpt-4o") | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
shall we add more tests for cases like missing http clients, wrong types...?
There was a problem hiding this comment.
The http client is not required. And if type is wrong, it will fail later, the user need to fix their code, I think this is not something we can handle internally.
There was a problem hiding this comment.
yea not super important but I meant double checking the intended behaviour is correct not only checking if the instance is of type OpenAILLM and AzureOpenAILLM in the unit tests.
There was a problem hiding this comment.
I see, tests updated, but hold on for a rereview, I'm rethinking a bit the solution
stellasia
force-pushed
the
fix/openai-httpx-client
branch
from
9343071 to
e2ab6f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #401
Type of Change
Complexity
Complexity:
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):