Support UTC DateTime Structures #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbiville
changed the title
bigmontz
reviewed
Jun 20, 2022
AndyHeap-NeoTech
approved these changes
Jun 23, 2022
AndyHeap-NeoTech
left a comment
AndyHeap-NeoTech
left a comment
There was a problem hiding this comment.
It looks ok to me. However I've not spent so much time deep in thought on this, so perhaps worth getting one of the other driver authors to review as well.
fbiville
force-pushed
the
utc_fix
branch
2 times, most recently
from
d5de5ac to
48265b8
Compare
Signed-off-by: Florent Biville <[email protected]>
Signed-off-by: Florent Biville <[email protected]>
Co-authored-by: grant lodge <[email protected]>
- fix type and value serialization - fix tz name serialization
Contributor
Author
|
The only failing test here is flaky. Merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ TestKit PR is: neo4j-drivers/testkit#470
✅ Extra TestKit PR: neo4j-drivers/testkit#495