Implement unified logger with log level - part 1 #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keremgocen
requested review from
MacondoExpress,
mjfwebb and
neo4j-team-graphql
keremgocen
commented
Nov 13, 2025
| } | ||
|
|
||
| // Initialize logger | ||
| log := logger.New(cfg.LogLevel, cfg.LogFormat, os.Stderr) |
Contributor
Author
There was a problem hiding this comment.
Initially we can set the level, format and the output stream, as long as it implements the io.Writer interface.
keremgocen
changed the title
…fied-logger-for-MCP
keremgocen
commented
Nov 14, 2025
| }) | ||
|
|
||
| t.Run("all log levels can be set dynamically", func(t *testing.T) { | ||
| levels := []string{"debug", "info", "notice", "warn", "warning", "error", "critical", "alert", "emergency"} |
Contributor
Author
There was a problem hiding this comment.
we probably won't need this many levels, but it's in the spec https://modelcontextprotocol.io/specification/draft/server/utilities/logging#log-levels
keremgocen
commented
Nov 14, 2025
| Params := args.Params | ||
|
|
||
| log.Printf("cypher-query: %s", Query) | ||
| deps.Log.Info("executing read cypher query", "query", Query) |
Contributor
Author
There was a problem hiding this comment.
I'd keep this as a debug instead, but VSCode MCP client is setting the log level to Info and I could not find a way to change that. Not sure if we want cypher queries to be logged all the time?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a logging service to enhance error handling and debugging capabilities across various components of the application. Update configuration to include log level and format, and ensure that logging is integrated into the server and tool dependencies.
WIP: only integrated for the get-schema tool for now. Tests to follow.
Part 1: (in this PR)
logger only implemented for the get-schema tool for nowimplemented for all toolsPart 2: (not in this PR)
https://linear.app/neo4j/issue/DEVSURF-806/design-and-create-logger-to-handle-logging-in-the-mcp-server