Skip to content

Make stub server fail hard on OS errors #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 14, 2023
Merged

Make stub server fail hard on OS errors #496

merged 11 commits into from
Apr 14, 2023

Conversation

@fbiville
Copy link
Contributor

Signed-off-by: Florent Biville [email protected]

@fbiville fbiville mentioned this pull request Jul 19, 2022
Merged
@robsdedude
Fix init bug in stub server
206c31a 
`Block.init` should advance its position if the its first child block gets
completed on `init`.
@robsdedude
Merge branch '5.0' into fail_hard_on_os_errors
6fd23a9
@robsdedude
Fix merge
8b9034b 
Internal API changed. More methods need access to the bolt channel.
@robsdedude
Fix init of BlockList
297dd37
robsdedude
robsdedude approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@robsdedude robsdedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡

@robsdedude
Fix test
bbd304e 
The fix of init made the server correctly shut down turning a read timeout into
a read on a broken socket in one test.
@robsdedude
Merge branch '5.0' into fail_hard_on_os_errors
c1dcdb8
@robsdedude
Copy link
Contributor

Seems like some tests make the assumption that loosing connectivity in the middle of the script is fine 🕵️

@robsdedude
Fix tests
ebe127a 
When a tests expects the driver to hang up the connection in the middle of the
script, it shouldn't check for the script to be fully played with
`server.done()`.
@robsdedude
Fix scripts that accepted conversation after GOODBYE
39361c5
@robsdedude
Merge branch '5.0' into fail_hard_on_os_errors
ad40115
@robsdedude robsdedude merged commit b3299b7 into 5.0 Apr 14, 2023
@robsdedude robsdedude deleted the fail_hard_on_os_errors branch April 14, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robsdedude robsdedude robsdedude approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fbiville @robsdedude