Optimize VM hot paths and add targeted benchmarks #4230
+470
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cschuchardt88
requested changes
Oct 16, 2025
Comment on lines
+51
to
+60
| var length = end - start; | ||
| if (length == 0) | ||
| return System.Array.Empty<StackItem>(); | ||
|
|
||
| return reverseList.GetRange(start, end - start); | ||
| StackItem[] result = new StackItem[length]; | ||
| var sourceIndex = _innerList.Count - start - 1; | ||
| for (int i = 0; i < length; i++) | ||
| result[i] = _innerList[sourceIndex - i]; | ||
|
|
||
| return result; |
There was a problem hiding this comment.
Please change this back there is a good reason why I wrote it the way I did. Can you explain your reasoning why you changed it? This way uses a loop. So, having big lists of data, you'll see performance issues come up. You guys tried to change it this way before.
We talked about it in a meeting about why its written this way from #4050
There was a problem hiding this comment.
this is a draft, do not review
There was a problem hiding this comment.
I just saying it so your aware of what your doing. I want you to succeed.
src/Neo.VM/EvaluationStack.cs
Outdated
Comment on lines
89
to
90
| for (int i = 0; i < _innerList.Count; i++) | ||
| stack._innerList.Add(_innerList[i]); |
There was a problem hiding this comment.
These loops are so inefficient.
|
Why are all the PRs you submitted marked as WIP/Draft? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Benchmark comparison (mean)