Skip to content

Optimize: use explicitly typed parameters instead of JArray in RpcMethod #4125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2025
+264 −299
Merged

Optimize: use explicitly typed parameters instead of JArray in RpcMethod #4125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c66cb31
Optimize: use expilict type instead of JArray in RpcMethod
Wi1l-B0t Aug 6, 2025
ae0672f
Merge branch 'dev' into optimize.use-RpcMethod-instead-part2
shargon Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/Plugins/RpcServer/ParameterConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,15 @@ internal static Address ToAddress(this JToken token, byte version)
return new Address(scriptHash, version);
}

internal static Address[] ToAddresses(this JToken token, byte version)
{
if (token is null) return null;
if (token is not JArray array)
throw new RpcException(RpcError.InvalidParams.WithData($"Invalid Addresses: {token}"));

return array.Select(p => ToAddress(p, version)).ToArray();
}

private static ContractParameter[] ToContractParameters(this JToken token)
{
if (token is null) return null;
Expand Down
Loading
Loading