Skip to content

Clean JsonSerializer #4113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 6, 2025
Merged

Clean JsonSerializer #4113

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
08c9e5b
Remove unused method
shargon Aug 4, 2025
7165321
Obsolete
shargon Aug 4, 2025
cd9ebf0
Update src/Neo/SmartContract/JsonSerializer.cs
shargon Aug 5, 2025
dbc0d74
Merge branch 'dev' into json-clean
shargon Aug 5, 2025
f164d82
Merge branch 'dev' into json-clean
NGDAdmin Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Neo/SmartContract/JsonSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ public static class JsonSerializer
/// </summary>
/// <param name="item">The <see cref="StackItem"/> to serialize.</param>
/// <returns>The serialized object.</returns>
[Obsolete]
public static JToken Serialize(StackItem item)
{
switch (item)
Expand Down
87 changes: 0 additions & 87 deletions tests/Neo.UnitTests/SmartContract/UT_JsonSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,17 +72,6 @@ public void JsonTest_Array()
Assert.AreEqual("[1,\"a==\",-1.3,null]", parsed.ToString());
}

[TestMethod]
public void JsonTest_Serialize_Map_Test()
{
var entry = new Map
{
[new byte[] { 0xC1 }] = 1,
[new byte[] { 0xC2 }] = 2,
};
Assert.ThrowsExactly<DecoderFallbackException>(() => _ = JsonSerializer.Serialize(entry));
}

[TestMethod]
public void JsonTest_Bool()
{
Expand Down Expand Up @@ -210,34 +199,6 @@ public void Deserialize_WrongJson()
Assert.ThrowsExactly<FormatException>(() => _ = JsonSerializer.Deserialize(engine, JObject.Parse("x"), ExecutionEngineLimits.Default));
}

[TestMethod]
public void Serialize_WrongJson()
{
Assert.ThrowsExactly<FormatException>(() => _ = JsonSerializer.Serialize(StackItem.FromInterface(new object())));
}

[TestMethod]
public void Serialize_EmptyObject()
{
var entry = new Map();
var json = JsonSerializer.Serialize(entry).ToString();

Assert.AreEqual("{}", json);
}

[TestMethod]
public void Serialize_Number()
{
var entry = new Array { 1, 9007199254740992 };
Assert.ThrowsExactly<InvalidOperationException>(() => _ = JsonSerializer.Serialize(entry));
}

[TestMethod]
public void Serialize_Null()
{
Assert.AreEqual(JObject.Null, JsonSerializer.Serialize(StackItem.Null));
}

[TestMethod]
public void Deserialize_EmptyObject()
{
Expand All @@ -249,15 +210,6 @@ public void Deserialize_EmptyObject()
Assert.AreEqual(0, ((Map)items).Count);
}

[TestMethod]
public void Serialize_EmptyArray()
{
var entry = new Array();
var json = JsonSerializer.Serialize(entry).ToString();

Assert.AreEqual("[]", json);
}

[TestMethod]
public void Deserialize_EmptyArray()
{
Expand All @@ -269,21 +221,6 @@ public void Deserialize_EmptyArray()
Assert.AreEqual(0, ((Array)items).Count);
}

[TestMethod]
public void Serialize_Map_Test()
{
var entry = new Map
{
["test1"] = 1,
["test3"] = 3,
["test2"] = 2
};

var json = JsonSerializer.Serialize(entry).ToString();

Assert.AreEqual("{\"test1\":1,\"test3\":3,\"test2\":2}", json);
}

[TestMethod]
public void Deserialize_Map_Test()
{
Expand All @@ -305,16 +242,6 @@ public void Deserialize_Map_Test()
CollectionAssert.AreEqual(map.Values.Select(u => u.GetInteger()).ToArray(), new BigInteger[] { 123, 321 });
}

[TestMethod]
public void Serialize_Array_Bool_Str_Num()
{
var entry = new Array { true, "test", 123 };

var json = JsonSerializer.Serialize(entry).ToString();

Assert.AreEqual("[true,\"test\",123]", json);
}

[TestMethod]
public void Deserialize_Array_Bool_Str_Num()
{
Expand All @@ -333,20 +260,6 @@ public void Deserialize_Array_Bool_Str_Num()
Assert.AreEqual(array[3].GetInteger(), BigInteger.Parse("90500000000000000000000000000"));
}

[TestMethod]
public void Serialize_Array_OfArray()
{
var entry = new Array
{
new Array { true, "test1", 123 },
new Array { true, "test2", 321 }
};

var json = JsonSerializer.Serialize(entry).ToString();

Assert.AreEqual("[[true,\"test1\",123],[true,\"test2\",321]]", json);
}

[TestMethod]
public void Deserialize_Array_OfArray()
{
Expand Down
Loading