-
Notifications
You must be signed in to change notification settings - Fork 1k
[Optimization] - Optimize key method #4001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| // Copyright (C) 2015-2025 The Neo Project. | ||
| // | ||
| // Benchmarks.Cache.cs file belongs to the neo project and is free | ||
| // software distributed under the MIT software license, see the | ||
| // accompanying file LICENSE in the main directory of the | ||
| // repository or http://www.opensource.org/licenses/mit-license.php | ||
| // for more details. | ||
| // | ||
| // Redistribution and use in source and binary forms with or without | ||
| // modifications are permitted. | ||
|
|
||
| using BenchmarkDotNet.Attributes; | ||
| using System; | ||
| using System.Security.Policy; | ||
|
|
||
| namespace Neo.Cryptography.MPTTrie.Benchmarks | ||
| { | ||
| public class Benchmarks_Cache | ||
| { | ||
| private readonly byte _prefix = 0x01; | ||
| private readonly UInt256 _hash; | ||
|
|
||
| public Benchmarks_Cache() | ||
| { | ||
| var randomBytes = new byte[UInt256.Length]; | ||
| new Random(42).NextBytes(randomBytes); | ||
| _hash = new UInt256(randomBytes); | ||
| } | ||
|
|
||
| [Benchmark] | ||
| public byte[] Key_Original() | ||
| { | ||
| var buffer = new byte[UInt256.Length + 1]; | ||
| using (var ms = new MemoryStream(buffer, true)) | ||
| using (var writer = new BinaryWriter(ms)) | ||
| { | ||
| writer.Write(_prefix); | ||
| _hash.Serialize(writer); | ||
| } | ||
| return buffer; | ||
| } | ||
|
|
||
| [Benchmark] | ||
| public byte[] Key_Optimized() | ||
| { | ||
| var buffer = new byte[UInt256.Length + 1]; | ||
| buffer[0] = _prefix; | ||
| _hash.GetSpan().CopyTo(buffer.AsSpan(1)); | ||
| return buffer; | ||
| } | ||
| } | ||
| } |
18 changes: 18 additions & 0 deletions
18
Neo.Cryptography.MPTTrie.Benchmarks/Neo.Cryptography.MPTTrie.Benchmarks.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>net9.0</TargetFramework> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="BenchmarkDotNet" Version="0.14.0" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\src\Neo\Neo.csproj" /> | ||
| </ItemGroup> | ||
|
|
||
| </Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| // Copyright (C) 2015-2025 The Neo Project. | ||
| // | ||
| // Program.cs file belongs to the neo project and is free | ||
| // software distributed under the MIT software license, see the | ||
| // accompanying file LICENSE in the main directory of the | ||
| // repository or http://www.opensource.org/licenses/mit-license.php | ||
| // for more details. | ||
| // | ||
| // Redistribution and use in source and binary forms with or without | ||
| // modifications are permitted. | ||
|
|
||
| using BenchmarkDotNet.Running; | ||
|
|
||
| // List all benchmarks: | ||
| // dotnet run -c Release --framework [for example: net9.0] -- --list flat(or tree) | ||
| // Run a specific benchmark: | ||
| // dotnet run -c Release --framework [for example: net9.0] -- -f [benchmark name] | ||
| // Run all benchmarks: | ||
| // dotnet run -c Release --framework [for example: net9.0] -- -f * | ||
| // Run all benchmarks of a class: | ||
| // dotnet run -c Release --framework [for example: net9.0] -- -f '*Class*' | ||
| // More options: https://benchmarkdotnet.org/articles/guides/console-args.html | ||
| BenchmarkSwitcher.FromAssembly(typeof(Program).Assembly).Run(args); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoided buffer creation