Skip to content
Closed
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
3b7cd98
improve: scan operations for ReadOnlyStoreView
nan01ab Jan 21, 2025
6ccb8ca
improve: scan operations for ReadOnlyStoreView
nan01ab Jan 22, 2025
5628012
Improve: add more comments
nan01ab Jan 22, 2025
a81b8f6
Update src/Neo/Extensions/Persistence/ReadOnlyViewExtensions.cs
shargon Jan 22, 2025
16c9ef2
Merge branch 'master' into feat.scan-readonly-storeview
shargon Jan 22, 2025
86a8d75
Improve: use ArrayExtensions.Repeat instead
nan01ab Jan 22, 2025
77fb843
Improve: use ArrayExtensions.Repeat instead
nan01ab Jan 22, 2025
7477f87
Fix code format and add more comments
nan01ab Jan 22, 2025
1bb8715
Merge branch 'master' into feat.scan-readonly-storeview
Jan 23, 2025
0c7767a
Merge branch 'master' into feat.scan-readonly-storeview
cschuchardt88 Jan 23, 2025
3dde742
Update src/Neo/Persistence/ReadOnlyStoreView.cs
nan01ab Jan 23, 2025
746b2ad
Update src/Neo/Extensions/Persistence/ReadOnlyViewExtensions.cs
nan01ab Jan 23, 2025
c06a38d
Update src/Neo/Extensions/Persistence/ReadOnlyViewExtensions.cs
nan01ab Jan 23, 2025
1eb7e1e
Update src/Neo/Extensions/Persistence/ReadOnlyViewExtensions.cs
nan01ab Jan 24, 2025
eb26415
Merge branch 'master' into feat.scan-readonly-storeview
shargon Jan 24, 2025
bf905fe
Merge branch 'master' into feat.scan-readonly-storeview
shargon Jan 26, 2025
b5bc0e7
Merge branch 'master' into feat.scan-readonly-storeview
shargon Jan 27, 2025
976dd32
Merge branch 'master' into feat.scan-readonly-storeview
cschuchardt88 Jan 31, 2025
5beabbc
Update src/Neo/Extensions/Persistence/ReadOnlyViewExtensions.cs
nan01ab Jan 31, 2025
4d7f58a
Fix: unit test issue
nan01ab Jan 31, 2025
46c28a8
Merge branch 'master' into feat.scan-readonly-storeview
Feb 1, 2025
a417172
fix: merge conflict
nan01ab Feb 1, 2025
f959ca4
Merge branch 'master' into feat.scan-readonly-storeview
nan01ab Feb 1, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/Neo.UnitTests/Extensions/UT_ReadOnlyViewExtension.cs
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ public void TestFindEmptyPrefix()
action.Should().Throw<ArgumentException>();

action = () => dataCache.Find([0xff], SeekDirection.Backward).ToArray();
action.Should().Throw<ArgumentException>();
action.Should().Throw<NotSupportedException>();
Copy link
Member

@cschuchardt88 cschuchardt88 Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using [0xff] should work. The way leveldb and rocksdb all work is, it seeks to the key 0xff and moves backwards from there.

so results would be in this order:

1. 0xff
2. 0xfe
3. 0xfd
4. 0xfc
5. 0xfb
6. 0xfa
7. ...etc...

All you have to do is use ByteArrayComparer class. I dont understand what the problem is or why no one can change this. its only 2 lines of code.

}
}
}
Expand Down