[Plugin RpcServer] fix issue 3629 #3630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jim8y
requested review from
AnnaShaleva,
Hecate2,
cschuchardt88,
nan01ab,
shargon and
superboyiii
Jim8y
commented
Dec 17, 2024
| args[i] = param.DefaultValue; | ||
| } | ||
| else if (param.ParameterType.IsValueType && Nullable.GetUnderlyingType(param.ParameterType) == null) | ||
| else if (param.ParameterType.IsValueType && |
Contributor
Author
There was a problem hiding this comment.
these are made automatically by dotnet format.
Jim8y
commented
Dec 17, 2024
Comment on lines
378
to
381
| catch (RpcException ex) | ||
| { | ||
| return CreateErrorResponse(request["id"], ex.GetError()); | ||
| } |
Hecate2
previously approved these changes
Dec 17, 2024
Contributor
Hecate2
left a comment
Hecate2
left a comment
There was a problem hiding this comment.
May be better if ParameterConverter.ConvertParameter throws something else, instead of RpcException.
Contributor
roman-khimov
left a comment
roman-khimov
left a comment
There was a problem hiding this comment.
What's gonna be the HTTP return code this way? 200?
Contributor
200 with an error code like -32602 in the json response body |
superboyiii
approved these changes
Dec 17, 2024
Member
superboyiii
left a comment
superboyiii
left a comment
There was a problem hiding this comment.
It works correctly, although it changes the original behaviour for message. I'm not sure it's good or not since these messages are not useless for debug.
Original(v3.7.5):
Current:
AnnaShaleva
reviewed
Dec 17, 2024
Contributor
|
LGTM |
nan01ab
reviewed
Dec 17, 2024
nan01ab
approved these changes
Dec 18, 2024
Hecate2
approved these changes
Dec 18, 2024
shargon
approved these changes
Dec 18, 2024
AnnaShaleva
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr fixes #3629 to handle rpcexception catch.
Fixes # #3629
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: